Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix JavaScript lint errors issue #6334 #6340

Closed
wants to merge 3 commits into from
Closed

chore: fix JavaScript lint errors issue #6334 #6340

wants to merge 3 commits into from

Conversation

Kavyansh-Bagdi
Copy link
Contributor

Resolves #6334

Description

What is the purpose of this pull request?
This pull request addresses the JavaScript linting issues by adding appropriate ESLint ignore comments for the following warnings:

  • max-statements: The createSourceFile function has a large number of statements.
  • max-lines: The loops.js file exceeds 300 lines, with a total of 836 LOC.
  • cspell:ignore: Added for stdbool, which is a recognized C header file.
  • no-warning-comments: Suppressed the warning for the intentional WARNING comment.

This ensures cleaner linting results without modifying the core logic.

Related Issues

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?

No additional information.

Checklist

Please ensure the following tasks are completed before submitting this pull request:

@stdlib-js/reviewers

@Kavyansh-Bagdi
chore: move longest-common-prefix to pacakage
a3d077a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Kavyansh-Bagdi
chore: added comment to ignore stdbool
ea2c416 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Kavyansh-Bagdi
chore: added comment to ignore max-statement and max-line
da2d996 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Mar 24, 2025
@Kavyansh-Bagdi Kavyansh-Bagdi changed the title chore: fix JavaScript lint errors (issue #6334 chore: fix JavaScript lint errors issue #6334 Mar 24, 2025
@kgryte
Copy link
Member

kgryte commented Mar 24, 2025

Hello, unfortunately, I'll need to close this PR, as it includes undesired changes. Lint warnings are not required to be addressed. We are only looking for actual lint errors to be resolved. Thanks for taking a look, and we look forward to your future contributions.

@kgryte kgryte closed this Mar 24, 2025
@kgryte kgryte added Invalid Invalid question, issue, or pull request. and removed Needs Review A pull request which needs code review. labels Mar 24, 2025
@Kavyansh-Bagdi Kavyansh-Bagdi deleted the jsLint branch March 24, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Invalid Invalid question, issue, or pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants
@Kavyansh-Bagdi @kgryte @stdlib-bot