Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constants/float32/max-safe-lucas #6374

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Mar 25, 2025

Progresses #649 .

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float32/max-safe-lucas .

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@hrshya hrshya changed the title feat: add constants/float32/max-safe-lucas feat: add constants/float32/max-safe-lucas Mar 25, 2025
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 25, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 25, 2025

Coverage Report

Package Statements Branches Functions Lines
constants/float32/max-safe-lucas $\color{green}49/49$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}49/49$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@hrshya hrshya requested a review from gunjjoshi March 26, 2025 16:21
@kgryte
Copy link
Member

kgryte commented Apr 2, 2025

@gunjjoshi Would you mind giving this one another review?

gunjjoshi
gunjjoshi previously approved these changes Apr 2, 2025
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Apr 2, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 2, 2025
@kgryte kgryte merged commit 0d59526 into stdlib-js:develop Apr 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants