Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for accessor arrays and refactor stats/base/stdevwd #6527

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat: add support for accessor arrays and refactor stats/base/stdevwd #6527

wants to merge 6 commits into from

Conversation

Ari1009
Copy link

@Ari1009 Ari1009 commented Apr 3, 2025 •
edited
Loading

Resolves #5685

Description

What is the purpose of this pull request?

This pull request:

  • add refactor and add protocol support to stats/base/stdevwd

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Apr 3, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 3, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/stdevwd $\color{red}274/278$
$\color{green}+98.56\%$ 		$\color{red}11/13$
$\color{green}+84.62\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{red}274/278$
$\color{green}+98.56\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title feat: add support for accessor arrays and refactor stats/base/stdevwd feat: add support for accessor arrays and refactor stats/base/stdevwd Apr 3, 2025
@kgryte kgryte requested a review from aayush0325 April 3, 2025 04:02
aayush0325
aayush0325 requested changes Apr 3, 2025
View reviewed changes
Copy link
Member

@aayush0325 aayush0325 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly address the CI failures and use #6248 as a reference PR, follow the conventions of benchmarks, examples docs, tests etc

aayush0325
aayush0325 reviewed Apr 3, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/stdevwd/docs/types/index.d.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tabs instead of spaces

aayush0325
aayush0325 reviewed Apr 3, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/stdevwd/docs/types/test.ts Outdated
@@ -28,6 +28,17 @@ import stdevwd = require( './index' );
stdevwd( x.length, 1, x, 1 ); // $ExpectType number
}

// The function supports accessor arrays...
{
const accessorArray = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use @stdlib/array/base/accessor here and elsewhere

@Ari1009 Ari1009 requested a review from aayush0325 April 5, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aayush0325 aayush0325 Awaiting requested review from aayush0325

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor and add protocol support to stats/base/stdevwd
3 participants
@Ari1009 @stdlib-bot @aayush0325