Skip to content

Make generated patches deterministic (iterate dicts, not sets) #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make generated patches deterministic (iterate dicts, not sets) #174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a78fe0d
create new test file
angela-tarantula Oct 11, 2025
35aebed
iterate directly over dicts, not sets
angela-tarantula Oct 11, 2025
07d8dda
remove unnecessary test file
angela-tarantula Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions jsonpatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,19 +859,20 @@ def _item_replaced(self, path, key, item):
}, pointer_cls=self.pointer_cls))

def _compare_dicts(self, path, src, dst):
src_keys = set(src.keys())
dst_keys = set(dst.keys())
added_keys = dst_keys - src_keys
removed_keys = src_keys - dst_keys

for key in removed_keys:
self._item_removed(path, str(key), src[key])

for key in added_keys:
self._item_added(path, str(key), dst[key])

for key in src_keys & dst_keys:
self._compare_values(path, key, src[key], dst[key])
# removed keys
for key in src:
if key not in dst:
self._item_removed(path, str(key), src[key])

# added keys
for key in dst:
if key not in src:
self._item_added(path, str(key), dst[key])

# shared keys
for key in src:
if key in dst:
self._compare_values(path, key, src[key], dst[key])

def _compare_lists(self, path, src, dst):
len_src, len_dst = len(src), len(dst)
Expand Down