sane_ancestor_ids and simplify specs #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're validating the column, it doesn't make sense to validate it against a string when the column only accepts integers properly defining the table primary key
siblings should probably not return themselves and siblings of roots should not return nodes at all
kbrock
commented
Aug 9, 2020
| @@ -116,6 +116,10 @@ def ancestry_changed? | |||
| end | |||
| end | |||
|
|
|||
| def sane_ancestor_ids? | |||
| valid? || errors[self.ancestry_base_class.ancestry_column].blank? | |||
| end | |||
There was a problem hiding this comment.
this will probably get merged back in when this concept changes. But probably good enough for now
kbrock
commented
Aug 9, 2020
| @@ -55,12 +59,12 @@ def test_order_by | |||
| AncestryTestDatabase.with_model :depth => 3, :width => 3 do |model, roots| | |||
| # not thrilled with this. mac postgres has odd sorting requirements | |||
| if ENV["DB"].to_s =~ /pg/ && RUBY_PLATFORM !~ /x86_64-darwin/ | |||
| expected = model.all.sort_by { |m| [m.ancestry.to_s.gsub('/',''), m.id.to_i] } | |||
| expected = model.all.sort_by { |m| [m.ancestor_ids.map(&:to_s).join, m.id.to_i] } | |||
There was a problem hiding this comment.
the goal is to focus on a single format agnostic field
kbrock
commented
Aug 9, 2020
| @@ -8,42 +8,29 @@ def test_ancestry_column_validation | |||
| node.send :write_attribute, model.ancestry_column, value | |||
| node.valid?; assert node.errors[model.ancestry_column].blank? | |||
| end | |||
| ['1/3/', '/2/3', 'a', 'a/b', '-34', '/54'].each do |value| | |||
There was a problem hiding this comment.
we used to focus that the format of this field was serialized correctly.
The new functionality parses these values just fine.
And since we are moving the serialization to a single method - the chances of failure is much lower than when this field was formed all over the code.
|
/review request @d-m-u |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce sane_ancestor_ids
specs going towards
ancestor_idsPrep for ancestor_ids work -- #481