Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

fix: strip .git off url properly #43

Merged
merged 1 commit into from
Sep 29, 2020
Merged

fix: strip .git off url properly #43

merged 1 commit into from
Sep 29, 2020

Conversation

docwhat
Copy link
Contributor

@docwhat docwhat commented Sep 24, 2020

basename is too aggressive and removes the hostname and path.

@docwhat
fix: strip .git off url properly
5e27efb 
`basename` is too aggressive and removes the hostname and path.
@docwhat
Copy link
Contributor Author

docwhat commented Sep 24, 2020

This does what I think #41 is trying to do.

Closes: #41

stefanprodan
stefanprodan approved these changes Sep 29, 2020
View reviewed changes
Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan merged commit 1e61958 into stefanprodan:master Sep 29, 2020
@docwhat docwhat deleted the pr-docwhat/fix-git-url-munging branch September 29, 2020 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@docwhat @stefanprodan