Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice values support #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Slice values support #110

wants to merge 1 commit into from

Conversation

Hamdy
Copy link

@Hamdy Hamdy commented Sep 3, 2020

Bases on comment :: #47 (comment)

@aurimasniekis
Copy link

Hi, any progress on this?

@philipp-classen
Copy link

Support for binary data would be useful. When I tried with the PR, writing binary data worked. Yet reading will still result in everything being wrapped as String. At least, in the pub/sub API that I tried, I had to change the API from String to String | Bytes:
https://github.com/Hamdy/crystal-redis/blob/22c24afe811f7fa119cf59e223c8e8dea832dd5f/src/redis/strategy/subscription_loop.cr#L54

Changing the API from String to String | Bytes is a breaking change. I wonder if there is a good solution.

@niko
Copy link

niko commented Sep 7, 2021

Any progress here? I just stumbled over this … being able to store binary data would really come in handy right now.

@robacarp
Copy link
Collaborator

robacarp commented Sep 7, 2021

This is a fine approach, but in order to be merged it would need to have some tests written around it so that it doesn't silently start to fail in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants