Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format string for read events cli command. #16

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Conversation

stegm
Copy link
Owner

@stegm stegm commented Aug 20, 2024

Fix for #15

Summary by Sourcery

Fix the format string in the CLI command for reading events to ensure the event description is correctly displayed.

Bug Fixes:

  • Correct the format string in the CLI command for reading events to properly interpolate the event description.

Copy link

sourcery-ai bot commented Aug 20, 2024

Reviewer's Guide by Sourcery

This pull request fixes a bug in the format string used for printing read events in the CLI command. The change replaces a regular string with an f-string to properly interpolate the event description.

File-Level Changes

Files Changes
pykoplenti/cli.py Changed a regular string to an f-string for proper variable interpolation in the print statement

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stegm - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@stegm stegm merged commit 10093f0 into master Sep 14, 2024
3 checks passed
@stegm stegm deleted the fix_event_desc branch September 14, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant