Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables the sag command to automatically default to the "speak" subcommand when text is piped in via stdin, mimicking the behavior of macOS's say command. This allows users to pipe text directly to sag without explicitly specifying the "speak" subcommand.
Changes:
- Modified
maybeDefaultToSpeak()to detect piped stdin and inject the "speak" subcommand when no arguments are provided - Added test coverage for the new piped stdin behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/root.go | Added logic to check if stdin is a TTY and inject "speak" subcommand for piped input |
| cmd/root_test.go | Added test to verify "speak" is injected when stdin is piped |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: