Make publish-dry-run-v2 work without a list of crates and deprecate v1 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
commented
Jul 16, 2024
|
Testing out the workflow here: |
|
It works! And is ready to merge and use. |
fnando
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make publish-dry-run-v2 work without a list of crates and deprecate v1.
Why
v1 was able to work out what crates to publish, but it had an issue that showed up only on some repos where it would trigger cargo looking up crates on crates.io before they had been published which would fail because the process of packaging the crates for a dry run wasn't preserving the order or using the local registry.
v2 was written to replace v1 but v2 was written requiring an explicit list of crates in the order to publish to avoid the lookups on crates.io.
This change makes v2 no longer require the explicit list by using cargo-workspaces (the tool we use to do actual publishes) to produce a list of crates that need publishing in the order they need publishing.
With this change v2 now works with the same inputs as v1 and so v1 can be completely deprecated and can call through to v2.
Even though the crates list input is no longer needed it remains for backwards compatibility.