-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to hide ingestion enabled flag from --help output #4955
Add functionality to hide ingestion enabled flag from --help output #4955
Conversation
services/horizon/internal/integration/ingestion_filtering_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me. Would be good to get another set of 👀 to review it as well. Also, there are a few linter warnings, it'll be great if you could address those as well. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry to reflect this change. Also, we need to update the public documentation for ingestion filtering with these modifications.
services/horizon/internal/integration/ingestion_filtering_test.go
Outdated
Show resolved
Hide resolved
@aditya1702 , you can add |
# Conflicts: # services/horizon/internal/flags.go
services/horizon/internal/integration/ingestion_filtering_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, left a few minor comments on test coverage, thanks for evaluating the feedback.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Closes #4906
Hidden
config option which makes it easy to hide flags from our --help output.--exp-enable-ingestion-filtering
since it is now enabled by default.Why
Ingestion filtering is now always enabled and does not require user specified flag.
Known limitations
[TODO or N/A]