Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump XDR once more #5023

Merged
merged 7 commits into from
Aug 31, 2023
Merged

Bump XDR once more #5023

merged 7 commits into from
Aug 31, 2023

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Aug 22, 2023

Bump XDR to 7015193879e9da7cb70d889a49eecf494fefe7e1

The integration tests won't work until soroban-rpc has been updated (the corresponding soroban-rpc PR is stellar/stellar-cli#884 ).

@tsachiherman
Copy link
Contributor

currently fails due to

2023-08-30T15:12:51.3784642Z     sac_test.go:1072: 
2023-08-30T15:12:51.3785849Z         	Error Trace:	/home/runner/work/go/go/services/horizon/internal/integration/sac_test.go:1072
2023-08-30T15:12:51.3787270Z         	            				/home/runner/work/go/go/services/horizon/internal/integration/sac_test.go:50
2023-08-30T15:12:51.3787829Z         	Error:      	Received unexpected error:
2023-08-30T15:12:51.3797683Z         	            	horizon error: "Transaction Failed" (tx_failed, resource_limit_exceeded) - check horizon.Error.Problem for more information
2023-08-30T15:12:51.3798395Z         	Test:       	TestContractMintToAccount

I'm going to beef up logging around that one, but the core issue is likly to be solved in the rpc fee calculations.

@2opremio
Copy link
Contributor Author

I'm going to beef up logging around that one, but the core issue is likly to be solved in the rpc fee calculations.

Yes, I am on it with @sisuresh on Slack.

@2opremio 2opremio marked this pull request as ready for review August 31, 2023 09:50
@2opremio 2opremio merged commit 1d913a1 into master Aug 31, 2023
36 checks passed
@2opremio 2opremio deleted the bump-xdr-once-more branch August 31, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants