services/horizon/ingest: Use buffered storage backend for reingest command #5374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* services/horizon: Reingest from precomputed TxMeta * udpate config * Fix govet error
…om datastore (#5380) * services/horizon: Reingest from precomputed TxMeta * Global network config for reingestion * Remove AlwaysIngest option since Ingest is now true by default
tamirms
reviewed
Jul 10, 2024
* services/horizon: Reingest from precomputed TxMeta * Global network config for reingestion * Add unit test for new --ledgerbackend flag * Fix unit test * Add unittest for network flags validation
urvisavla
reviewed
Jul 15, 2024
sreuland
commented
Jul 16, 2024
chowbao
reviewed
Jul 16, 2024
tamirms
reviewed
Jul 16, 2024
tamirms
reviewed
Jul 16, 2024
tamirms
reviewed
Jul 16, 2024
tamirms
reviewed
Jul 16, 2024
tamirms
reviewed
Jul 16, 2024
tamirms
reviewed
Jul 16, 2024
tamirms
reviewed
Jul 16, 2024
… bucket files, review feedback
tamirms
reviewed
Jul 16, 2024
tamirms
reviewed
Jul 16, 2024
…ds for DataStore, BufferedStorageBackend, review feedback
…xec error, make sure close db conn regardless during test shutdown
…n test during test
…me parameters_test cases due to ingest bug stated in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Change
db reingestcommand to accept additional configuration parameters to use a new buffered storage ledger backend(consumes precomputed tx meta files generated from ledger exporter) instead of using captive core backend. There is currently one implementation of the buffered storage reader available, so will see reference on that often which is for Google Cloud Storage(GCS) backend.Refer to new Reingestion readme docs for details on the invoking
db reingest range <from> <to>with new configuration via--ledgerbackendand--datastore-configparametersCaptive core remains the default ledger backend in all cases still, reingestion commands or on live/forward ingestion. Only reingestion allows config to override the ledger backend type.
Coauthors: @urvisavla
Why
Faster reingestion speeds. Ingestion from precomputed tx meta files is faster than consuming same tx meta from captive core pipe.
Closes #4911
Known limitations
only affects reingestion command. Requires an authenticatable GCP cloud connection and the cloud data store must be maintained(receiving data files) from a running ledger exporter process, which is out of band from here.