Preserve existing auth entries after simulation if they're present #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreuland
reviewed
Jul 27, 2023
| xdr.SorobanAuthorizationEntry.fromXDR(a, "base64") | ||
| ) ?? [] | ||
| ), | ||
| // if auth entries are already present, we consider this "advanced |
There was a problem hiding this comment.
minor suggestion, this is really good description on the new behavior for auth based on incoming tx, which could be included in public facing js doc on prepareTransaction()
There was a problem hiding this comment.
great idea! done in 12973ee
sreuland
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In complex auth scenarios, you may have signed entries that would be overwritten by simulation, so this just uses your existing entries. This should not affect "new" or "fresh" simulations just like before.