-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release w/ support for stable Protocol 20 and RPC. #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
changed the title
[Draft] Upgrade library to work with stable XDR
[Draft] Upgrade library to work with stable XDR and RPC
Oct 26, 2023
3 tasks
This was referenced Oct 31, 2023
Shaptic
changed the title
[Draft] Upgrade library to work with stable XDR and RPC
[Draft] Release v1.0.0-rc.1 w/ support for stable Protocol 20 and RPC.
Nov 30, 2023
Shaptic
force-pushed
the
stable
branch
2 times, most recently
from
November 30, 2023 22:10
bea200c
to
ae26bef
Compare
Shaptic
added a commit
to stellar/js-stellar-sdk
that referenced
this pull request
Dec 1, 2023
Merged
4 tasks
Shaptic
changed the title
[Draft] Release v1.0.0-rc.1 w/ support for stable Protocol 20 and RPC.
Release v1.0.0-rc.1 w/ support for stable Protocol 20 and RPC.
Dec 5, 2023
Shaptic
requested review from
sreuland and
stellarsaur
and removed request for
sreuland
December 5, 2023 17:09
Shaptic
changed the title
Release v1.0.0-rc.1 w/ support for stable Protocol 20 and RPC.
Prepare release w/ support for stable Protocol 20 and RPC.
Dec 5, 2023
sreuland
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, since changing system-test to use js-stellar-sdk, unfortunately won't have e2e coverage on this lib anymore, but is deprecated.
Shaptic
added a commit
to stellar/js-stellar-sdk
that referenced
this pull request
Dec 6, 2023
…#886) * Add all changes matching stellar/js-soroban-client#167 * Refresh yarn.lock * Fixup Node versions, etc. * Rename stable package under the `@stellar/` organization (#887)
willemneal
pushed a commit
to AhaLabs/js-stellar-sdk
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a staging ground for all of the changes necessary to get an SDK compatible with the upcoming stable release of Protocol 20. This PR is a conglomeration of PRs that have already been approved:
Note that this work will also need to be ported to the stellar-sdk.