Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK Modernization #69

Merged
merged 9 commits into from
May 18, 2023
Merged

SDK Modernization #69

merged 9 commits into from
May 18, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Apr 20, 2023 •
edited

In line with stellar/js-stellar-sdk#814, this refreshes the build system to use the latest&greatest in JS build pipelines.

It also bumps the minor version to v0.6.0.

@Shaptic Shaptic mentioned this pull request May 17, 2023
Closed
chadoh
chadoh approved these changes May 17, 2023
View reviewed changes
Copy link

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

sreuland
sreuland approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, a veritable clinic, my approval is lightweight, look forward to porting this to soroban branch, you mentioned it resolves the webpack issue on js-xdr dependency from stellar-base:9.0.0-soroban.1, thanks!

aristidesstaffieri
aristidesstaffieri approved these changes May 18, 2023
View reviewed changes
Copy link

@aristidesstaffieri aristidesstaffieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🎉

@Shaptic Shaptic merged commit 678bbaa into main May 18, 2023
@Shaptic Shaptic deleted the modernize branch May 18, 2023 16:21
@Shaptic Shaptic mentioned this pull request May 18, 2023
Closed
@chadoh
Copy link

chadoh commented May 24, 2023

Seems like soroban-client no longer ships with TypeScript types. Is this change the cause?

@chadoh
Copy link

chadoh commented May 24, 2023

Why use babel at all? Why not just build with TypeScript?

@Shaptic
Copy link
Contributor Author

Shaptic commented May 24, 2023

that was a bug; #86 should have fixed it (part of v0.7.0)

as for Babel, I think we still need it to be able to control the output targets?

@chadoh
Copy link

chadoh commented May 24, 2023

You mean this? https://www.typescriptlang.org/tsconfig#target

I'll try 0.7.0, especially now that futurenet has been updated! Thanks.

@Shaptic
Copy link
Contributor Author

Shaptic commented May 25, 2023

Yeah so that one is nice but it's not granular enough, I think. Babel lets you target specific browser versions, market share, etc.

Actually, thinking about it more, we could probably get away with just using tsc here tbh. I need to figure out whether or not ES6 matches up with Babel's > 2% as I outlined in #90, and then we can drop it (would be sweet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadoh chadoh chadoh approved these changes

@aristidesstaffieri aristidesstaffieri aristidesstaffieri approved these changes

@quietbits quietbits quietbits approved these changes

@sreuland sreuland sreuland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Shaptic @chadoh @aristidesstaffieri @quietbits @sreuland