-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Republish package under @stellar/ scope #714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -823 B (0%) Total Size: 3.19 MB
|
stellarsaur
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the very minor GitHub Actions warnings
e289c24
to
6e4377e
Compare
CassioMG
approved these changes
Nov 21, 2023
Shaptic
added a commit
that referenced
this pull request
Dec 5, 2023
…#710) * Upgrade XDR to the final, stable testnet version. (#704, #715) XDR has been upgraded to the latest stable version. This is mostly renames, but it includes the following relevant breaking changes: - `Operation.bumpFootprintExpiration` is now `extendFootprintTtl` and its `ledgersToExpire` field is now named `extendTo`, but it serves the same purpose. - `xdr.ContractExecutable.contractExecutableToken` is now `contractExecutableStellarAsset` - `xdr.SorobanTransactionData.refundableFee` is now `resourceFee` - In turn, `SorobanDataBuilder.setRefundableFee` is now `setResourceFee` - This new fee encompasses the entirety of the Soroban-related resource fees. Note that this is distinct from the "network-inclusion" fee that you would set on your transaction (i.e. `TransactionBuilder(..., { fee: ... })`). - In TypeScript, the `Operation.BumpFootprintExpiration` is now `Operation.ExtendFootprintTtl` Commit: stellar/stellar-xdr @ bb54e50 * Add helpful abstractions for common invocation types. (#703) * Drop incorrect key entry for contract footprint (#709) * Republish package under @stellar/ scope (#714)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that this is targeting the
stable
branch: we will only include this rename as part of the stable package release.See stellar/js-xdr#111, stellar/js-xdr#112, and stellar/js-xdr#113 for what was needed in that package to accomplish this.
This also moves the code to use
@stellar/js-xdr
instead ofjs-xdr
.Related: stellar/js-stellar-sdk#851.