Skip to content

Commit

Permalink
Fixup and revert unneeded changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Shaptic committed Oct 13, 2023
1 parent 0b08af8 commit 1ab6696
Show file tree
Hide file tree
Showing 6 changed files with 238 additions and 253 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -995,7 +995,7 @@ Many thanks to @Ffloriel and @Akuukis for their help with this release!

- Add types for LedgerCallBuilder.ledger.
- Add types for Server.operationFeeStats.
- Add types for the Horizon.AxiosClient export.
- Add types for the HorizonAxiosClient export.
- Move @types/\* from devDependencies to dependencies.
- Pass and use a stream response type to CallBuilders if it's different from the
normal call response.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
"bignumber.js": "^9.1.2",
"eventsource": "^2.0.2",
"randombytes": "^2.1.0",
"stellar-base": "10.0.0-beta.1",
"stellar-base": "10.0.0-beta.3",
"toml": "^3.0.0",
"urijs": "^1.19.1"
}
Expand Down
13 changes: 6 additions & 7 deletions src/horizon/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export class Server {
/**
* Fetch the fee stats endpoint.
* @see [Fee Stats](https://developers.stellar.org/api/aggregations/fee-stats/)
* @returns {Promise<HorizonApi.FeeStatsResponse>} Promise that resolves to the fee stats returned by Api.
* @returns {Promise<HorizonApi.FeeStatsResponse>} Promise that resolves to the fee stats returned by Horizon.
*/
public async feeStats(): Promise<HorizonApi.FeeStatsResponse> {
const cb = new CallBuilder<HorizonApi.FeeStatsResponse>(
Expand Down Expand Up @@ -742,15 +742,14 @@ export class Server {
* Check if any of the destination accounts requires a memo.
*
* This function implements a memo required check as defined in
* [SEP0029](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0029.md).
* It will load each account which is the destination and check if it has the
* data field `config.memo_required` set to `"MQ=="`.
* [SEP-29](https://stellar.org/protocol/sep-29). It will load each account
* which is the destination and check if it has the data field
* `config.memo_required` set to `"MQ=="`.
*
* Each account is checked sequentially instead of loading multiple accounts
* at the same time from Api.
* at the same time from Horizon.
*
* @see
* [SEP0029](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0029.md)
* @see https://stellar.org/protocol/sep-29
* @param {Transaction} transaction - The transaction to check.
* @returns {Promise<void, Error>} - If any of the destination account
* requires a memo, the promise will throw {@link AccountRequiresMemoError}.
Expand Down
4 changes: 1 addition & 3 deletions src/soroban/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ import {

export const SUBMIT_TRANSACTION_TIMEOUT = 60 * 1000;

/**
* Specifies the durability namespace of contract-related ledger entries.
*/
/** Specifies the durability namespace of contract-related ledger entries. */
export enum Durability {
Temporary = 'temporary',
Persistent = 'persistent'
Expand Down
Loading

0 comments on commit 1ab6696

Please sign in to comment.