Skip to content

Commit

Permalink
Make Node 16 the minimum version. (#847)
Browse files Browse the repository at this point in the history
* Bump babel compilation target
  • Loading branch information
Shaptic committed Jul 18, 2023
1 parent e0a8181 commit b5eac57
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/gh_pages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
repository: stellar/js-stellar-base
path: js-stellar-base

- name: Install Node (14.x)
- name: Install Node (16.x)
uses: actions/setup-node@v3
with:
node-version: '14.x'
node-version: 16

- name: Install Dependencies
run: yarn install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: '14.x'
node-version: 16
registry-url: 'https://registry.npmjs.org'

- name: Install Depencencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
fail-fast: false
max-parallel: 4
matrix:
node-version: [14, 16, 18]
node-version: [16, 18, 20]

steps:
- name: Checkout
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,16 +134,16 @@ cd js-stellar-sdk
npm install
```

3. Install Node 14
3. Install Node 16

Because we support the oldest maintenance version of Node, please install and develop on Node 14 so you don't get surprised when your code works locally but breaks in CI.
Because we support the oldest maintenance version of Node, please install and develop on Node 16 so you don't get surprised when your code works locally but breaks in CI.

Here's how to install `nvm` if you haven't: https://github.com/creationix/nvm

```shell
nvm install

# if you've never installed 14 before you'll want to re-install yarn
# if you've never installed 16 before you'll want to re-install yarn
npm install -g yarn
```

Expand Down
2 changes: 1 addition & 1 deletion babel.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"production": {
"comments": false,
"targets": {
"node": 14,
"node": 16,
"browsers": [
"> 2%",
"ie 11",
Expand Down

0 comments on commit b5eac57

Please sign in to comment.