Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop all usage of URI to make tree-shaking urijs dependency possible #832

Closed
wants to merge 12 commits into from

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented May 22, 2023

What

Replaces usage of URI (from urijs) with native URL.

There is still a reliance on urijs's URITemplate API for building URLs from Horizon's _links responses, but this should still lower bundle size as its an explicit, standalone import.

Why

Reducing bundle size, see #824.

Assets: 
  stellar-sdk.js (1.83 MiB)
  stellar-sdk.min.js (685 KiB)

Known Limitations

Is this worth it? Tests pass, but this might break in subtle ways.

@Shaptic Shaptic linked an issue May 23, 2023 that may be closed by this pull request
@Shaptic Shaptic marked this pull request as ready for review June 6, 2023 16:41
Copy link

@aristidesstaffieri aristidesstaffieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I suspect we can drop uri.js entirely in favor of native URL + template strings but that's another topic.

@Shaptic Shaptic closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Investigate and drop urijs as a dependency.
2 participants