Drop forced eventsource polyfill to opt-in to streaming support

[Shaptic]

The presence of the eventsource dependency is a problem for many deployment environments. It's also a polyfill that is non-essential for environments with native support for the EventSource API. Furthermore, not everyone needs streaming support.

This PR drops this dependency from being installed by default and warns downstream about the implications if the API is not present.

Its presence is still necessary in devDependencies for running tests related to streaming. Downstream developers can avoid installing these by using npm i --production stellar-sdk.

[github-actions]

Size Change: -1.56 MB (-14%) 👏

Total Size: 9.64 MB

Filename	Size	Change
dist/stellar-sdk.js	5.38 MB	-807 kB (-13%)	👏
dist/stellar-sdk.min.js	4.26 MB	-753 kB (-15%)	👏

_{compressed-size-action}

[silence48]

Let's merge it. beautiful idea.

[silence48]

I love it and strongly support!

[kalepail]

Lgtm! Haven't tested though. Would that be helpful before merging or are we confident in the change?

[Shaptic]

@tyvdh it'd be super helpful lol

[kalepail]

Get a different error. But still an error

✘ [ERROR] Could not resolve "https"

    node_modules/.pnpm/github.com+stellar+js-stellar-sdk@29aaf8a11a17b34de65feeddd60f033125af22a9/node_modules/stellar-sdk/node_modules/eventsource/lib/eventsource.js:3:20:
      3 │ var https = require('https')
        ╵                     ~~~~~~~

  The package "https" wasn't found on the file system but is built into node.
  Add "node_compat = true" to your wrangler.toml file to enable Node.js compatibility.


✘ [ERROR] Could not resolve "http"

    node_modules/.pnpm/github.com+stellar+js-stellar-sdk@29aaf8a11a17b34de65feeddd60f033125af22a9/node_modules/stellar-sdk/node_modules/eventsource/lib/eventsource.js:4:19:
      4 │ var http = require('http')
        ╵                    ~~~~~~

  The package "http" wasn't found on the file system but is built into node.
  Add "node_compat = true" to your wrangler.toml file to enable Node.js compatibility.

[kalepail]

I'm using pnpm vs npm so not sure if or how they handle this --production flag. I'm not familiar with that flag. If I use npm directly with that flag I get this error

service core:user:colorglyph-worker: Uncaught Error: Cannot find module 'eventsource'
  at index.js:53676:28 in webpackMissingModule
  at index.js:53679:18 in 6881
  at index.js:75582:43 in __webpack_require__
  at index.js:57323:61 in 8026
  at index.js:75582:43 in __webpack_require__
  at index.js:49844:59 in 5085
  at index.js:75582:43 in __webpack_require__
  at index.js:75656:37
  at index.js:75658:11
  at index.js:36374:26 in webpackUniversalModuleDefinition

[kalepail]

@Shaptic here's a boilerplate repo for testing on a CF worker
https://github.com/tyvdh/stellar-worker-boilerplate
Hopefully proves helpful :)

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@haverstack/axios-fetch-adapter	0.8.0	network	+1	413 kB	cuibonobo

[Shaptic]

@tyvdh give it another shot! I think I got it 😎

[kalepail]

Just confirming I have tested this and it's working fine. SHIP IT
Not a huge fan of unmuteable alarms/alerts but that's a nit

[Shaptic]

@tyvdh lol the warning works if webpack is missing, but a subsequent npm i eventsource does not remove/fix the warning 😅

[kalepail]

Would love to see this branch updated and merged. I use it a lot and it's starting to fall behind

[kalepail]

Well 💩
I added a remote and accidentally pushed here instead of to my remote
Then I tried to revert
And now somehow I've closed this PR and can't seem to reopen it.
Oof