Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend .payments() call builder to encompass add'l non-payment types #885

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 28, 2023

As described by the docs, the /payments endpoint returns a collection of operations rather than, specifically, the Payment Operation:

Operations that can be returned by this endpoint include: create_account, payment, path_payment_strict_recieve, path_payment_strict_send, and account_merge.

This PR expands the types to the PaymentCallBuilder accordingly.

Note that this is a breaking change, because anyone using this call builder will now need to either cast the returned records or handle all of the variations.

Copy link

github-actions bot commented Nov 28, 2023

Size Change: +859 B (0%)

Total Size: 12.1 MB

Filename Size Change
dist/stellar-sdk.js 6.96 MB +455 B (0%)
dist/stellar-sdk.min.js 5.1 MB +404 B (0%)

compressed-size-action

@Shaptic Shaptic self-assigned this Nov 30, 2023
@Shaptic Shaptic added the bug label Nov 30, 2023
@Shaptic Shaptic merged commit c17718d into master Dec 1, 2023
8 checks passed
@Shaptic Shaptic deleted the payments-type-fixup branch December 1, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants