Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: performing 2nd swap not working #986

Closed
wants to merge 9 commits into from

Commits on Jun 7, 2024

  1. fix: performing 2nd swap not working

    The test added here is copying the first few steps of the previous test,
    "alice swaps bob 10 A for 1 B". For some reason, the second time you
    simulate this transaction, it is calculating that no non-invoker signing
    is needed! Haven't figured out why yet.
    
    Note that this is an order-dependent test. The new one only functions as
    expected because mocha runs the tests in the same order every time.
    chadoh committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d7fbc00 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Configuration menu
    Copy the full SHA
    e17d488 View commit details
    Browse the repository at this point in the history
  2. Adds AssembledTransaction.toXDR|fromXDR and Client.txFromXDR methods

    Adds a toXDR and fromXDR for AssembledTransaction class. 
    Also adds a txFromXDR to the Client class. 
    Changes the swap test to use this flow.
    
    Limitations: If you use the XDR multi-auth flow, you must re-simulate 
    before the final `signAndSend` call. This is due to the fact that we can't 
    serialize the XDR of the transaction envelope with the results of the 
    simulation. If we want to do this, we would need to add an 
    `AssembledTransaction` type to XDR in `stellar-base`.
    ---------
    
    Co-authored-by: George <[email protected]>
    BlaineHeffron and Shaptic committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    52b2006 View commit details
    Browse the repository at this point in the history
  3. Update simulationData after re-simulation (stellar#985)

    The new test added here shows that you can edit a transaction with
    `tx.raw = cloneFrom(tx.build)` and that the `tx.simulationData` will be
    updated correctly.
    chadoh authored and BlaineHeffron committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e5b5777 View commit details
    Browse the repository at this point in the history
  4. Add auto restore functionality for contract client (stellar#991)

    Co-authored-by: Chad Ostrowski <[email protected]>
    Co-authored-by: blaineheffron <[email protected]>
    Co-authored-by: George <[email protected]>
    3 people committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6e9f9bb View commit details
    Browse the repository at this point in the history
  5. Add separate sign and send methods to `contract.AssembledTransact…

    …ion` (stellar#992)
    
    * add auto restore functionality for contract client
    * extract getAccount to utils
    * add changelog entry for auto restore functionality
    
    Co-authored-by: Chad Ostrowski <[email protected]>
    Co-authored-by: blaineheffron <[email protected]>
    chadoh and BlaineHeffron committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    cae564f View commit details
    Browse the repository at this point in the history
  6. Release v12.1.0 (stellar#993)

    * Upgrade dev dependencies
    * Upgrade stellar-base to latest version
    Shaptic authored and BlaineHeffron committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    aa9c8f6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d28cc93 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    99a1715 View commit details
    Browse the repository at this point in the history