Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Transaction: time bounds timestamp human readable date #1105

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Build Transaction: time bounds timestamp human readable date #1105

merged 3 commits into from
Oct 23, 2024

Conversation

quietbits
Copy link
Contributor

@quietbits quietbits commented Oct 18, 2024 •
edited
Loading

image

image

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1105.previews.kube001.services.stellar-ops.com/

@quietbits quietbits linked an issue Oct 18, 2024 that may be closed by this pull request
Feature Request: Convert the unix timestamp you enter in the time bounds to human readable #428
Closed
@janewang
Copy link
Contributor

I think it's better if it's UTC.

By international convention, UTC is equivalent to GMT, however their measurements differ: GMT is measured from midday, whereas UTC is measured from midnight. UTC is the legal basis of time in the world.

@quietbits
Copy link
Contributor Author

I think it's better if it's UTC.

By international convention, UTC is equivalent to GMT, however their measurements differ: GMT is measured from midday, whereas UTC is measured from midnight. UTC is the legal basis of time in the world.

@janewang Sure, we can use the UTC timezone. The design showed GMT.

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1105.previews.kube001.services.stellar-ops.com/

jeesunikim
jeesunikim reviewed Oct 22, 2024
View reviewed changes
src/helpers/formatEpochToDate.ts
minute: "numeric",
second: "numeric",
hourCycle: "h24",
timeZone: "utc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming it doesn't matter whether this is capitalized or not (mdn doc)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, both seem to be correct values. Thanks for checking! 🙌

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1105.previews.kube001.services.stellar-ops.com/

@quietbits quietbits merged commit 7901902 into master Oct 23, 2024
3 checks passed
@quietbits quietbits deleted the tx-timestamp-date branch October 23, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeesunikim jeesunikim jeesunikim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Convert the unix timestamp you enter in the time bounds to human readable
4 participants
@quietbits @stellar-jenkins @janewang @jeesunikim