-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change custom_types contract to be equivalent to the one in soroban-cli #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I want to add that this will also allow us to use soroban contract init
to set up tests in stellar-cli, rather than include its own modified versions of soroban-examples
in the test-wasms
folder.
Note that a CI test for the custom_types contract is now failing |
formatting should be fixed now |
@BlaineHeffron @ElliotFriend @fnando, one Test is failing and I can't seem to have the permissions to re-run it. |
What
Changing custom_types contract to match the one in stellar-cli.
Why
This allows us to use
soroban client init
in thejs-stellar-sdk
instead of using prebuilt wasms. We needed functions to do tests on. I noticed that custom_types in this repo was identical to increment so I figured it was fine to change it.Close stellar/js-stellar-sdk#980
Known limitations
N/A