Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change custom_types contract to be equivalent to the one in soroban-cli #313

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

BlaineHeffron
Copy link
Contributor

@BlaineHeffron BlaineHeffron commented Jun 20, 2024

What

Changing custom_types contract to match the one in stellar-cli.

Why

This allows us to use soroban client init in the js-stellar-sdk instead of using prebuilt wasms. We needed functions to do tests on. I noticed that custom_types in this repo was identical to increment so I figured it was fine to change it.

Close stellar/js-stellar-sdk#980

Known limitations

N/A

Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I want to add that this will also allow us to use soroban contract init to set up tests in stellar-cli, rather than include its own modified versions of soroban-examples in the test-wasms folder.

@chadoh
Copy link
Contributor

chadoh commented Jun 20, 2024

Note that a CI test for the custom_types contract is now failing

@BlaineHeffron
Copy link
Contributor Author

formatting should be fixed now

@willemneal
Copy link
Member

willemneal commented Jun 24, 2024

@BlaineHeffron @ElliotFriend @fnando, one Test is failing and I can't seem to have the permissions to re-run it.

@fnando fnando merged commit 0288d25 into stellar:main Jun 27, 2024
114 checks passed
@BlaineHeffron BlaineHeffron deleted the feat/additions-for-tests branch June 27, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use soroban contract init to generate contracts for e2e tests
4 participants