all: Bump Core, rs-soroban-sdk and rs-soroban-env versions #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willemneal @paulbellamy FYI this PR will also be needed for the CLI. There is still a bunch of broken code on the CLI which is not a priority for #590 . I can take a look once I get soroban-rpc working. In the meantime, feel free to push fixes here if you like. |
2opremio
force-pushed
the
bump-core-image
branch
from
dee3904
to
b0d625d
Compare
2opremio
force-pushed
the
bump-core-image
branch
2 times, most recently
from
4eab572
to
5dc3f19
Compare
|
OK, I took a stab at the CLI changes. @willemneal @paulbellamy Could you take a look at them? |
2opremio
force-pushed
the
bump-core-image
branch
from
5dc3f19
to
d2bb96a
Compare
paulbellamy
reviewed
Apr 26, 2023
There was a problem hiding this comment.
Looks fine to me. One suggestion.
I'd like to see:
- unit tests for the number conversion
- what @willemneal thinks
2opremio
force-pushed
the
bump-core-image
branch
from
0445506
to
51ab153
Compare
|
@2opremio Looks good to me. I added a PR to move the conversions stuff to functions: 2opremio#2 But as @tsachiherman says that could be done in a future PR. |
willemneal
approved these changes
Apr 26, 2023
|
@paulbellamy / @tsachiherman can I get an approval? |
paulbellamy
approved these changes
Apr 26, 2023
|
@willemneal yeah, let's do it in a future PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Bump the Core, rs-soroban-sdk and rs-soroban-env versions
Why
#590
Known limitations
N/A