Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate test meta #3482

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MonsieurNicolas
Copy link
Contributor

This PR adds a new Github action (to be installed in the contributor's fork) that automatically adds the updates to the "test meta" in the background.

This makes it much easier and faster as contributors do not need to

  • remember to generate the updates
  • build both current and vnext and generate each

(this replaces #3401 )

@MonsieurNicolas MonsieurNicolas force-pushed the autoMeta branch 3 times, most recently from 2189bad to 8acebc0 Compare July 11, 2022 19:27
@MonsieurNicolas
Copy link
Contributor Author

Hold onto merging this: there is some unexpected meta update that I am still chasing

@MonsieurNicolas MonsieurNicolas force-pushed the autoMeta branch 4 times, most recently from 2a6ce7a to 7d82aed Compare July 16, 2022 05:18
@MonsieurNicolas
Copy link
Contributor Author

This is now good to go: the issue was that the test infra to run tests was only running a subset of tests per file (because of batching), which caused the meta to be only contain data from the last batch for each test file.

@sisuresh
Copy link
Contributor

sisuresh commented Aug 3, 2022

r+ b74fe83

@MonsieurNicolas
Copy link
Contributor Author

this is blocked on a change in bors (should allow "skipped" workflow, and only look at failed ones)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants