Change default test backend to BucketListDB #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirTyson
force-pushed
the
bl-test-audit
branch
4 times, most recently
from
69bab34
to
3dbfcb2
Compare
SirTyson
force-pushed
the
bl-test-audit
branch
8 times, most recently
from
9d56468
to
cc5599c
Compare
dmkozh
reviewed
Sep 13, 2024
SirTyson
force-pushed
the
bl-test-audit
branch
from
0337c35
to
ba1d0d2
Compare
marta-lokhova
previously approved these changes
Sep 14, 2024
SirTyson
force-pushed
the
bl-test-audit
branch
from
c3ad77e
to
c573704
Compare
marta-lokhova
approved these changes
Sep 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
#4466) # Description Fixes some acceptance tests that were affected by #4462. <!--- Describe what this pull request does, which issue it's resolving (usually applicable for code changes). ---> # Checklist - [ ] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes) document - [ ] Rebased on top of master (no merge commits) - [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio extension) - [ ] Compiles - [ ] Ran all tests - [ ] If change impacts performance, include supporting evidence per the [performance document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4433
This switches the default testing backend to BucketListDB. While some test still disable BucketListDB and commit directly via
LedgerTxnto test lower level subsystem, such as operation application, the majority of tests and all end-to-end tests no use BucketListDB. This is rebased on top of #4455.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)