Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contract getting started #520

Merged
merged 5 commits into from
May 2, 2024
Merged

Update contract getting started #520

merged 5 commits into from
May 2, 2024

Conversation

BlaineHeffron
Copy link
Contributor

Updates the smart contracts getting started tutorial to reflect the new ContractClient class in the js-stellar-sdk. Also fixes a typo of the hello world contract name.

ElliotFriend
ElliotFriend approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! Looks great

chadoh
chadoh approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a couple questions and notes, but none are show-stoppers. I think these are good changes that we should merge sooner rather than later, and then maybe follow up with more PRs later.

docs/smart-contracts/getting-started/create-an-app.mdx Show resolved Hide resolved
docs/smart-contracts/getting-started/create-an-app.mdx Outdated Show resolved Hide resolved
docs/smart-contracts/getting-started/create-an-app.mdx Outdated Show resolved Hide resolved
@chadoh chadoh mentioned this pull request Apr 30, 2024
Merged
@BlaineHeffron BlaineHeffron marked this pull request as draft May 1, 2024 15:43
@BlaineHeffron
Copy link
Contributor Author

I added the signTransaction method to the sign and send in the Counter script. This is needed based on how the current soroban astro template creates the Client. I also updated the url to the new stellar repo for the soroban astro template. I removed the timeoutInSeconds passed to the increment because it shouldn't be needed with the new default being set to 60 (see stellar/js-stellar-sdk#951). I simplified the logic for getting the public key in Counter.

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr520.previews.kube001.services.stellar-ops.com

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr520.previews.kube001.services.stellar-ops.com

@BlaineHeffron BlaineHeffron marked this pull request as ready for review May 2, 2024 20:45
@fnando fnando merged commit bf2451c into stellar:main May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadoh chadoh chadoh approved these changes

@ElliotFriend ElliotFriend ElliotFriend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BlaineHeffron @stellar-jenkins @chadoh @ElliotFriend @fnando