Add an XDR type for DiagnosticEvent<> #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MonsieurNicolas Does this need a protocol version? I don't think so. It's not used by anything explicitly, and implicitly the part of stellar-core that outputs this type (without using the type) is not part of the protocol anyway. |
dmkozh
approved these changes
May 13, 2024
bboston7
added a commit
to bboston7/stellar-xdr
that referenced
this pull request
May 17, 2024
This reverts commit 3adee2d. Temporarily reverting this commit so we can pull the updated overlay definitions into stellar-core without revving other dependencies.
sisuresh
pushed a commit
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add an XDR type DiagnosticEvents for DiagnosticEvent<>.
Why
Stellar-core returns a variable length array of diagnostic events from it's submission endpoint. It'd be convenient to be able to decode it on the command line with the CLI. We could add the ability to decode arbitrary arrays and other types to the CLI, but that's much more effort and adding a type definition for a type that stellar-core does output is easier and maybe the "right" way to do this anyway.
Supersedes: