Convert to .NET Standard 2.0. #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables log4net.Azure to compile as a .NET Standard 2.0 library.
Two things are not supported:
LocationInfo.StackFramesdoesn't seem to exist on the .NET Standard version oflog4net.CloudConfigurationManagerfromMicrosoft.Azure.ConfigurationManageris for .NET Framework only and not supported under .NET Standard.Beware it is a little hacky...
Microsoft.WindowsAzure.Storagehas changed most access methods into async, and so there are a bunch of.Wait(TIMEOUT)sprinkled all over the place. Poor programming practice, but works.Note: Sorry I messed up some files' formatting -- VS auto-formatted them when I saved.