Video: Basic implementation of MAVLink camera protocol #217
Conversation
|
Thanks! I should have some time in the next few days to review. |
|
Only major issue I'm seeing is that the "Enable camera heartbeats" (and streaming is active) checkbox doesn't remain ticked if I refresh the Video Streaming page. Perhaps the value isn't getting passed through correctly? |
|
I am seeing the same thing but really can't figure out why. As far as I can tell, the camera heartbeat setting is being saved and retrieved the exact same way as the timestamp setting, but only the heartbeat setting isn't getting retrieved properly. If you have time to take a closer look at the code, another pair of eyes would be much appreciated. |
server/index.js
Outdated
| @@ -427,6 +449,7 @@ app.get('/api/videodevices', (req, res) => { | |||
| error: null, | |||
| fps: fps, | |||
| FPSMax: FPSMax, | |||
| useCameraHeartbeat, | |||
There was a problem hiding this comment.
enableCameraHeartbeat: useCameraHeartbeat,
There was a problem hiding this comment.
Well that is an embarrassing thing to miss! Thanks for finding it.
|
I've added in a comment for fixing the non-appearing-checkbox. One other thing, you'll need to move the Video streaming service to below the UDP IP/port options in |
ddd999
force-pushed
the
camerainfo
branch
2 times, most recently
from
3729012 to
63a0c82
Compare
Both of these things should be fixed in the latest commit. Thanks for your help! |
|
Found another issue - the "Video source IP Address" doesn't appear to saved. It goes back to 127.0.0.1 whenever I refresh the page (with streaming active). |
Adds a MAVLink heartbeat output for the attached camera device, and adds the ability to send CAMERA_INFORMATION messages when requested. Also includes improvements for better handling undefined parameters for sendCommandAck() and sendHeartbeat() This completes a basic implementation of feature request stephendade#169.
That should be fixed now. There are a couple of other slight changes in the latest commit, to comply with the expected behaviour based on the MAVLink documentation. When RTP streaming is selected:
I noticed that Mission Planner recognizes the VIDEO_STREAM_INFORMATION message, and asks if you want to connect to the RTSP stream, which worked correctly when I tried it. MP seems to only ask this the first time it receives a message, though. It also doesn't appear to do this when the stream type is RTP. |
|
Looks good! Merging... |
Adds a MAVLink heartbeat output for the attached camera device, and adds the ability to send CAMERA_INFORMATION messages when requested.
Also includes improvements for better handling undefined parameters for sendCommandAck() and sendHeartbeat()
This completes a basic implementation of feature request #169.