Skip to content

Commit

Permalink
Merge branch 'winget-pkgs-AUTHORING-MANIFESTS-md' of https://github.c…
Browse files Browse the repository at this point in the history
…om/stephengillie/winget-pkgs into winget-pkgs-AUTHORING-MANIFESTS-md
  • Loading branch information
stephengillie committed Mar 7, 2024
2 parents 2e38cd7 + fb56c37 commit fbdb262
Show file tree
Hide file tree
Showing 21,342 changed files with 372,546 additions and 122,695 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
- [ ] This PR only modifies one (1) manifest
- [ ] Have you [validated](https://github.com/microsoft/winget-pkgs/blob/master/AUTHORING_MANIFESTS.md#validation) your manifest locally with `winget validate --manifest <path>`?
- [ ] Have you tested your manifest locally with `winget install --manifest <path>`?
- [ ] Does your manifest conform to the [1.5 schema](https://github.com/microsoft/winget-pkgs/tree/master/doc/manifest/schema/1.5.0)?
- [ ] Does your manifest conform to the [1.6 schema](https://github.com/microsoft/winget-pkgs/tree/master/doc/manifest/schema/1.6.0)?

Note: `<path>` is the name of the directory containing the manifest you're submitting.

Expand Down
2 changes: 2 additions & 0 deletions .github/actions/spelling/allow.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
appinstaller
appname
apps
appsandfeaturesentries
Expand Down Expand Up @@ -38,6 +39,7 @@ screenshots
Smartscreen
ssh
standalone
submitters
tada
Testplan
toolset
Expand Down
3 changes: 3 additions & 0 deletions .github/actions/spelling/excludes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,10 @@ ignore$
^\.(?!github/)
^\.github/actions/spelling/
^\.github/policies/moderatorTriggers\.yml$
^\.github/policies/superModeratorTriggers\.yml$
^\.github/policies/flaggedPackages\.yml$
^\.github/workflows/spellCheck\.yml$
^\.github/workflows/similarissues\.yml$
(?:^|/)Tools/
(?:^|/)manifests/
(?:^|/)DevOpsPipelineDefinitions/
2 changes: 2 additions & 0 deletions .github/actions/spelling/expect.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
admins
automerge
craigloewen
cspell
Daa
Esco
Expand All @@ -15,6 +16,7 @@ LOCALAPPDATA
mdanish
Megamix
misclicks
msft
quhxl
redistribution
russellbanks
Expand Down
7 changes: 5 additions & 2 deletions .github/policies/automergeTriggers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@ configuration:
- description: Enable Auto Merge when the "Validation-Completed" label is present
if:
- payloadType: Pull_Request
- hasLabel:
label: Validation-Completed
- or:
- labelAdded:
label: Validation-Completed
- hasLabel:
label: Validation-Completed
then:
- enableAutoMerge:
mergeMethod: Squash
Expand Down
40 changes: 40 additions & 0 deletions .github/policies/labelAdded.lastVersionRemaining.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
id: labelAdded.lastVersionRemaining
name: GitOps.PullRequestIssueManagement
description: Handlers when "Last-Version-Remaining" label is added
owner:
resource: repository
disabled: false
where:
configuration:
resourceManagementConfiguration:
eventResponderTasks:
- description: >-
When the label "Last-Version-Remaining" is added to a pull request
* Add a reply notifying the issue author
* Assign to the author
* Label with Needs-Author-Feedback
if:
- payloadType: Pull_Request
- labelAdded:
label: Last-Version-Remaining
then:
- addReply:
reply: >-
Hello @${issueAuthor},
This PR removes the last version of the package from the repository.
Please check if the package requires an update or is available from another source.
Template: msftbot/lastVersionRemaining
- assignTo:
author: True
- addLabel:
label: Needs-Author-Feedback
# The policy service should trigger even when the label was added by the policy service
triggerOnOwnActions: true
onFailure:
onSuccess:
72 changes: 72 additions & 0 deletions .github/policies/labelAdded.licenseBlocksInstall.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
id: labelAdded.licenseBlocksInstall
name: GitOps.PullRequestIssueManagement
description: Handlers when "License-Blocks-Install" label is added
owner:
resource: repository
disabled: false
where:
configuration:
resourceManagementConfiguration:
eventResponderTasks:
- description: >-
When the label "License-Blocks-Install" is added to a pull request
* Add the PR specific reply notifying the issue author of a blocking issue
* Label the PR with Blocking-Issue
* Label with Needs-Author-Feedback
* Remove the Needs-Attention Label
if:
- payloadType: Pull_Request
- labelAdded:
label: License-Blocks-Install
then:
- addReply:
reply: >-
Hello @${issueAuthor},
This package appears to require user to accept a license agreement before installation.
This PR is blocked until support for agreements is added to the community repository.
* See microsoft/winget-pkgs/issues/131328
Template: msftbot/blockingIssue/licenseBlocksInstall
- addLabel:
label: Blocking-Issue
- addLabel:
label: Needs-Author-Feedback
- removeLabel:
label: Needs-Attention
# The policy service should trigger even when the label was added by the policy service
triggerOnOwnActions: true
- description: >-
When the label "License-Blocks-Install" is added to an issue
* Add the issue specific reply notifying the issue author of a blocking issue
* Label the issue with Blocking-Issue
if:
- payloadType: Issues
- labelAdded:
label: License-Blocks-Install
then:
- addReply:
reply: >-
Hello @${issueAuthor},
This package appears to require user to accept a license agreement before installation.
This issue is blocked until support for agreements is added to the community repository.
* See microsoft/winget-pkgs/issues/131328
Template: msftbot/blockingIssue/licenseBlocksInstall
- addLabel:
label: Blocking-Issue
# The policy service should trigger even when the label was added by the policy service
triggerOnOwnActions: true
onFailure:
onSuccess:
2 changes: 1 addition & 1 deletion .github/policies/labelAdded.manifestVersionError.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ configuration:
Hello @${issueAuthor},
The package manager bot determined that the ManifestVersion key does not match any version currently approved for release. Please verify the manifest file is compliant with the package manager [1.3 manifest specification](https://github.com/microsoft/winget-pkgs/tree/master/doc/manifest/schema/1.3.0), [1.4 manifest specification](https://github.com/microsoft/winget-pkgs/tree/master/doc/manifest/schema/1.4.0), or [1.5 manifest specification](https://github.com/microsoft/winget-pkgs/tree/master/doc/manifest/schema/1.5.0).
The package manager bot determined that the ManifestVersion key does not match any version currently approved for release. Please verify the manifest file is compliant with the package manager [1.5 manifest specification](https://github.com/microsoft/winget-pkgs/tree/master/doc/manifest/schema/1.5.0) or [1.6 manifest specification](https://github.com/microsoft/winget-pkgs/tree/master/doc/manifest/schema/1.6.0).
For details on the specific error, see the details link below in the build pipeline.
Expand Down
78 changes: 78 additions & 0 deletions .github/policies/labelAdded.portableArchive.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
id: labelAdded.portableArchive
name: GitOps.PullRequestIssueManagement
description: Handlers when "portable-archive" label is added
owner:
resource: repository
disabled: false
where:
configuration:
resourceManagementConfiguration:
eventResponderTasks:
- description: >-
When the label "portable-archive" is added to a pull request
* Add the PR specific reply notifying the issue author of a blocking issue
* Label the PR with Blocking-Issue
* Label with Needs-Author-Feedback
* Remove the Needs-Attention Label
if:
- payloadType: Pull_Request
- labelAdded:
label: portable-archive
then:
- addReply:
reply: >-
Hello @${issueAuthor},
This package appears to require support for archive extraction.
This PR is blocked until support for additional archive formats is implemented in:
* microsoft/winget-cli/issues/2899
Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.
Template: msftbot/blockingIssue/additionalArchiveSupport
- addLabel:
label: Blocking-Issue
- addLabel:
label: Needs-Author-Feedback
- removeLabel:
label: Needs-Attention
# The policy service should trigger even when the label was added by the policy service
triggerOnOwnActions: true
- description: >-
When the label "portable-archive" is added to an issue
* Add the issue specific reply notifying the issue author of a blocking issue
* Label the issue with Blocking-Issue
if:
- payloadType: Issues
- labelAdded:
label: portable-archive
then:
- addReply:
reply: >-
Hello @${issueAuthor},
This package appears to require support for archive extraction.
This PR is blocked until support for additional archive formats is implemented in:
* microsoft/winget-cli/issues/2899
Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.
Template: msftbot/blockingIssue/additionalArchiveSupport
- addLabel:
label: Blocking-Issue
# The policy service should trigger even when the label was added by the policy service
triggerOnOwnActions: true
onFailure:
onSuccess:
78 changes: 0 additions & 78 deletions .github/policies/labelAdded.portableTar.yml

This file was deleted.

22 changes: 19 additions & 3 deletions .github/policies/labelManagement.issueUpdated.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ configuration:
label: Validation-Completed
- hasLabel:
label: Moderator-Approved
- hasLabel:
label: Azure-Pipeline-Passed
- and:
- not:
hasLabel:
Expand Down Expand Up @@ -302,6 +300,8 @@ configuration:
label: Validation-Forbidden-URL-Error
- removeLabel:
label: Validation-Domain
- removeLabel:
label: Validation-Missing-Dependency
- removeLabel:
label: Blocking-Issue
- removeLabel:
Expand Down Expand Up @@ -364,6 +364,20 @@ configuration:
label: Manifest-Content-Incomplete
- removeLabel:
label: Validation-Open-Url-Failed
- removeLabel:
label: Last-Version-Remaining
- removeLabel:
label: New-Manifest
- removeLabel:
label: New-Package
- removeLabel:
label: Manifest-Metadata-Consistency
- removeLabel:
label: Manifest-Version-Deprecated
- removeLabel:
label: Version-Parameter-Mismatch
- removeLabel:
label: Validation-Line-Endings-Error
- description: Remove status labels when a PR is re-run
if:
- payloadType: Issue_Comment
Expand All @@ -384,7 +398,7 @@ configuration:
- activitySenderHasPermission:
permission: Write
then:
# Don't remove Changes-Requested here beacause it is just a re-run, no new commits have been added
# Don't remove Changes-Requested here because it is just a re-run, no new commits have been added
- removeLabel:
label: Validation-Completed
- removeLabel:
Expand Down Expand Up @@ -443,6 +457,8 @@ configuration:
label: Validation-Unapproved-URL
- removeLabel:
label: Validation-Domain
- removeLabel:
label: Validation-Missing-Dependency
- removeLabel:
label: Blocking-Issue
- removeLabel:
Expand Down
Loading

1 comment on commit fbdb262

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@check-spelling-bot Report

🔴 Please review

See the 📜action log for details.

Unrecognized words (9)

BDCE
DFAF
differring
Familyname
HKEY
MSIINSTALLPERUSER
schemae
Upgradecode
Workarounds

Previously acknowledged words that are now absent admins craigloewen Daa Esco fabricbot Filezilla jedieaston Joakim Kad Karan Levvie mdanish Megamix msft quhxl redistribution russellbanks Tbot timezone Trenly :arrow_right:
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:stephengillie/winget-pkgs.git repository
on the winget-pkgs-AUTHORING-MANIFESTS-md branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/stephengillie/winget-pkgs/actions/runs/8182619223/attempts/1'
Pattern suggestions ✂️ (1)

You could add these patterns to .github/actions/spelling/patterns.txt:

# Automatically suggested patterns
# hit-count: 2 file-count: 1
# uuid:
\b[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}\b

Warnings (1)

See the 📜action log for details.

ℹ️ Warnings Count
ℹ️ candidate-pattern 1

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Please sign in to comment.