[Feature] Add group_unhandled_paths Option to Enhance filter_unhandled_paths Functionality #91#98
Merged
stephenhillier merged 1 commit intostephenhillier:masterfrom Jun 23, 2024
Conversation
stephenhillier
requested changes
Jun 21, 2024
Owner
stephenhillier
left a comment
There was a problem hiding this comment.
Looks great. I agree with your comments on the two options, having group_unhandled_paths override makes sense to me.
One thing I would say is that users who only set group_unhandled_paths will see the warning, even if they didn't intentionally set filter_unhandled_paths (since it defaults to True). That's a minor issue and we can always adjust the warning later if needed.
f32b57a to
37d3b09
Compare
Owner
|
Thanks for the update, looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title: Add
group_unhandled_pathsOption to Enhancefilter_unhandled_pathsFunctionalityHello @stephenhillier and @Filipoliko,
Following the discussion in the previous PR and the suggestions made, I have created an alternative PR (based on @Filipoliko solution) for handling unhandled paths.
Overview of the Changes:
group_unhandled_pathsoption.group_unhandled_paths: Similar tofilter_unhandled_paths, but instead of ignoring the requests, they are grouped under the__unknown__path. This option overridesfilter_unhandled_pathsby setting it toFalse. The default value isFalse.Reasoning:
group_unhandled_pathsprovides clear intend even iffilter_unhandled_pathsis enabled and simply it overrides it.I believe this solution addresses the concerns raised about having mutually exclusive options and makes the configuration more intuitive.
Please review this alternative approach and let me know your thoughts.