Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix packaging #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix packaging #1

wants to merge 3 commits into from

Conversation

bgoodri
Copy link

@bgoodri bgoodri commented Nov 26, 2016

I'm not sure why, but these commits allow your package to call rstan::sampling in parallel. It has something to do with putting methods into Depends: in the DESCRIPTION file and putting import(Rcpp) into the bDif.R file.
Also, you should be able to just put rstan into Imports: rather than Depends:.

@stephensrmmartin
Copy link
Owner

Thanks for this. I think the only issue was adding Rcpp to the namespace imports; once I added Rcpp to the namespace imports, it worked.

As for whether to keep rstan in imports or depends, I chose depends because I think the user would benefit from all the rstan summary and plotting functions, and Depends automatically attaches the rstan package for that purpose. Is that a bad idea?

And finally, I thought methods was no longer required importing, but perhaps I'm wrong (I thought as of some recent R version, methods is assumed attached, but maybe I'm wrong).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants