Skip to content

WebApi of remote start, remote stop and connector status #547

WebApi of remote start, remote stop and connector status

WebApi of remote start, remote stop and connector status #547

Triggered via pull request December 6, 2023 11:15
Status Success
Total duration 41s
Artifacts 1

review.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 10 warnings
checkstyle: src/main/java/de/rwth/idsg/steve/web/api/RemoteStartStopRestController.java#L276
[checkstyle] reported by reviewdog 🐶 Line has trailing spaces. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/web/api/RemoteStartStopRestController.java:276:0: error: Line has trailing spaces. (com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck)
checkstyle: src/main/java/de/rwth/idsg/steve/web/api/RemoteStartStopRestController.java#L315
[checkstyle] reported by reviewdog 🐶 Line has trailing spaces. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/web/api/RemoteStartStopRestController.java:315:0: error: Line has trailing spaces. (com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck)
checkstyle: src/main/java/de/rwth/idsg/steve/web/api/RemoteStartStopRestController.java#L317
[checkstyle] reported by reviewdog 🐶 Line has trailing spaces. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/web/api/RemoteStartStopRestController.java:317:0: error: Line has trailing spaces. (com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck)
checkstyle: src/main/java/de/rwth/idsg/steve/web/api/RemoteStartStopRestController.java#L358
[checkstyle] reported by reviewdog 🐶 Line has trailing spaces. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/web/api/RemoteStartStopRestController.java:358:0: error: Line has trailing spaces. (com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck)
Useless parentheses.: file:///home/runner/work/steve/steve/src/main/java/de/rwth/idsg/steve/repository/dto/TaskOverview.java#L54
Parenthesized expressions are used to override the default operator precedence rules. Parentheses whose removal would not change the relative nesting of operators are unnecessary, because they don't change the semantics of the enclosing expression. Some parentheses that strictly speaking are unnecessary, may still be considered useful for readability. This rule allows to ignore violations on two kinds of unnecessary parentheses: - "Clarifying" parentheses, which separate operators of difference precedence. While unnecessary, they make precedence rules explicit, which may be useful for rarely used operators. For example: ```java (a + b) & c // is equivalent to `a + b & c`, but probably clearer ``` Unset the property `ignoreClarifying` to report them. - "Balancing" parentheses, which are unnecessary but visually balance out another pair of parentheses around an equality operator. For example, those two expressions are equivalent: ```java (a == null) != (b == null) a == null != (b == null) ``` The parentheses on the right are required, and the parentheses on the left are just more visually pleasing. Unset the property `ignoreBalancing` to report them. UselessParentheses (Priority: 4, Ruleset: Code Style) https://docs.pmd-code.org/pmd-doc-7.0.0-rc4/pmd_rules_java_codestyle.html#uselessparentheses
Too many static imports may lead to messy code: file:///home/runner/work/steve/steve/src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java#L19
If you overuse the static import feature, it can make your program unreadable and unmaintainable, polluting its namespace with all the static members you import. Readers of your code (including you, a few months after you wrote it) will not know which class a static member comes from (Sun 1.5 Language Guide). TooManyStaticImports (Priority: 3, Ruleset: Code Style) https://docs.pmd-code.org/pmd-doc-7.0.0-rc4/pmd_rules_java_codestyle.html#toomanystaticimports
Unused static import 'de.rwth.idsg.steve.utils.CustomDSL.date': file:///home/runner/work/steve/steve/src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java#L57
Reports import statements that can be removed. They are either unused, duplicated, or the members they import are already implicitly in scope, because they're in java.lang, or the current package. UnnecessaryImport (Priority: 4, Ruleset: Code Style) https://docs.pmd-code.org/pmd-doc-7.0.0-rc4/pmd_rules_java_codestyle.html#unnecessaryimport
Unused static import 'de.rwth.idsg.steve.utils.CustomDSL.includes': file:///home/runner/work/steve/steve/src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java#L58
Reports import statements that can be removed. They are either unused, duplicated, or the members they import are already implicitly in scope, because they're in java.lang, or the current package. UnnecessaryImport (Priority: 4, Ruleset: Code Style) https://docs.pmd-code.org/pmd-doc-7.0.0-rc4/pmd_rules_java_codestyle.html#unnecessaryimport
Unused static import 'jooq.steve.db.tables.ChargeBox.CHARGE_BOX': file:///home/runner/work/steve/steve/src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java#L59
Reports import statements that can be removed. They are either unused, duplicated, or the members they import are already implicitly in scope, because they're in java.lang, or the current package. UnnecessaryImport (Priority: 4, Ruleset: Code Style) https://docs.pmd-code.org/pmd-doc-7.0.0-rc4/pmd_rules_java_codestyle.html#unnecessaryimport
Unused static import 'jooq.steve.db.tables.Connector.CONNECTOR': file:///home/runner/work/steve/steve/src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java#L60
Reports import statements that can be removed. They are either unused, duplicated, or the members they import are already implicitly in scope, because they're in java.lang, or the current package. UnnecessaryImport (Priority: 4, Ruleset: Code Style) https://docs.pmd-code.org/pmd-doc-7.0.0-rc4/pmd_rules_java_codestyle.html#unnecessaryimport
Unused static import 'jooq.steve.db.tables.ConnectorStatus.CONNECTOR_STATUS': file:///home/runner/work/steve/steve/src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java#L61
Reports import statements that can be removed. They are either unused, duplicated, or the members they import are already implicitly in scope, because they're in java.lang, or the current package. UnnecessaryImport (Priority: 4, Ruleset: Code Style) https://docs.pmd-code.org/pmd-doc-7.0.0-rc4/pmd_rules_java_codestyle.html#unnecessaryimport
Too many static imports may lead to messy code: file:///home/runner/work/steve/steve/src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java#L19
If you overuse the static import feature, it can make your program unreadable and unmaintainable, polluting its namespace with all the static members you import. Readers of your code (including you, a few months after you wrote it) will not know which class a static member comes from (Sun 1.5 Language Guide). TooManyStaticImports (Priority: 3, Ruleset: Code Style) https://docs.pmd-code.org/pmd-doc-7.0.0-rc4/pmd_rules_java_codestyle.html#toomanystaticimports
Unused static import 'de.rwth.idsg.steve.utils.CustomDSL.date': file:///home/runner/work/steve/steve/src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java#L46
Reports import statements that can be removed. They are either unused, duplicated, or the members they import are already implicitly in scope, because they're in java.lang, or the current package. UnnecessaryImport (Priority: 4, Ruleset: Code Style) https://docs.pmd-code.org/pmd-doc-7.0.0-rc4/pmd_rules_java_codestyle.html#unnecessaryimport
Unused static import 'jooq.steve.db.tables.ChargeBox.CHARGE_BOX': file:///home/runner/work/steve/steve/src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java#L47
Reports import statements that can be removed. They are either unused, duplicated, or the members they import are already implicitly in scope, because they're in java.lang, or the current package. UnnecessaryImport (Priority: 4, Ruleset: Code Style) https://docs.pmd-code.org/pmd-doc-7.0.0-rc4/pmd_rules_java_codestyle.html#unnecessaryimport

Artifacts

Produced during runtime
Name Size
PMD Report Expired
19.2 KB