migrate "header value" as "api password" to database (#1540) #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goekay
force-pushed
the
1540-store-web-api-key-in-database-addendum
branch
from
55f08ee to
9e5dd8d
Compare
goekay
force-pushed
the
1540-store-web-api-key-in-database-addendum
branch
from
9e5dd8d to
014f5ae
Compare
goekay
changed the title
juherr
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @MaticBobnar @fluppie @juherr
i addressed the initial starting point only (i.e. there is no user in db at all), upon which this creates the admin user with password and api_password. i did not target your "partial" state (admin user was created, but api_password was not set).
you can tell me if you are okay with this solution.
context: #1582