Conversation
reason: they were needed for native spring. we dont need them with spring boot.
Closed
goekay
force-pushed
the
1733-migrate-to-spring-boot
branch
from
9a86e24 to
dc0e2c1
Compare
reason: they are from the era before spring boot
Contributor
|
That's an awesome move! I didn't expect it could be wrapped up so easily, great job! |
* translation of properties to native spring boot properties with prefixes server.* and spring.* * convert SteveConfiguration singleton into spring bean SteveProperties with remainder of steve-specific properties * during this conversion we lost the property "https.port": spring does not natively support the embedded server to open a second port/connector. it is still possible programmatically, but i am not sure whether it is worth it, if spring's default behaviour does not contain in. if this breaks some workflows/setups, we can reconsider in the future. tests will fail big time. fixes will come in subsequent commit.
goekay
force-pushed
the
1733-migrate-to-spring-boot
branch
from
947b9b9 to
ddf7e3a
Compare
Member
Author
|
mariadb tests are failing because of #1371 |
goekay
force-pushed
the
1733-migrate-to-spring-boot
branch
from
d729a29 to
156734c
Compare
reason: most libs (and their versions) come from spring boot
reason: spring-boot-starter-validation does it already
we are not using the commit id anywhere anymore
juherr
reviewed
Sep 21, 2025
Member
Author
|
interesting observation: the application at the HEAD of master takes between 2 and 3 seconds to start. the application at this branch takes between 4 and 5 seconds to start. 2 seconds difference is not much in absolute terms. but the start-up is 2x slower in relative terms which is kinda huge. edit: these numbers can be different on other machines. but running both versions of the app probably would result in a similar slowdown. |
goekay
force-pushed
the
1733-migrate-to-spring-boot
branch
from
3239fd5 to
8eca250
Compare
juherr
reviewed
Sep 21, 2025
juherr
added a commit
to juherr/evolve
that referenced
this pull request
Sep 23, 2025
Member
Author
|
@juherr (or others) do you have any other feedback for this PR? otherwise i would like to merge it. |
Contributor
|
LGTM. You might also want to check the AI review on juherr#120 I haven’t gone through it yet, but you may find some useful insights there. |
applied some of the relevant suggestions by AI review
juherr
added a commit
to juherr/evolve
that referenced
this pull request
Sep 25, 2025
juherr
added a commit
to juherr/evolve
that referenced
this pull request
Sep 25, 2025
juherr
added a commit
to juherr/evolve
that referenced
this pull request
Sep 25, 2025
juherr
added a commit
to juherr/evolve
that referenced
this pull request
Sep 26, 2025
juherr
added a commit
to juherr/evolve
that referenced
this pull request
Sep 29, 2025
juherr
added a commit
to juherr/evolve
that referenced
this pull request
Sep 29, 2025
juherr
added a commit
to juherr/evolve
that referenced
this pull request
Sep 29, 2025
juherr
added a commit
to juherr/evolve
that referenced
this pull request
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1733
project compiles and tests succeed. the app runs.
some further improvements and refactors are possible.
open TODOs: