Skip to content

migrate "header key" as "api password" to database (#1540) #1364

migrate "header key" as "api password" to database (#1540)

migrate "header key" as "api password" to database (#1540) #1364

GitHub Actions / checkstyle completed Oct 27, 2024 in 1s

reviewdog [checkstyle] report

reported by reviewdog 🐶

Findings (1)

src/main/java/de/rwth/idsg/steve/service/WebUserService.java|88 col 13| Avoid inline conditionals.

Filtered Findings (269)

src/main/java/de/rwth/idsg/steve/SteveAppContext.java|80| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/SteveAppContext.java|174| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/SteveAppContext.java|196| Line is longer than 120 characters (found 131).
src/main/java/de/rwth/idsg/steve/repository/impl/UserRepositoryImpl.java|166| Line is longer than 120 characters (found 127).
src/main/java/de/rwth/idsg/steve/repository/impl/ReservationRepositoryImpl.java|163| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/repository/impl/ReservationRepositoryImpl.java|174 col 116| '+' should be on a new line.
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|104| Line is longer than 120 characters (found 139).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|147| Line is longer than 120 characters (found 127).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|251| Line is longer than 120 characters (found 148).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|337| Line is longer than 120 characters (found 214).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|339| Line is longer than 120 characters (found 167).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|106| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|106 col 64| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|122| Line is longer than 120 characters (found 146).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|122 col 60| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|124| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|124 col 66| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|277| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|279| Line is longer than 120 characters (found 149).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|279 col 108| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|283| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|313| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|313 col 92| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|359| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|87| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|111| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|256| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|258| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/repository/impl/GenericRepositoryImpl.java|76 col 90| '+' should be on a new line.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|91| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|93 col 13| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|268| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|268 col 77| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|353| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|368| Line is longer than 120 characters (found 125).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|169| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|307 col 23| Variable 'existsAlready' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|308 col 19| Variable 'transactionId' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|443 col 85| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|444 col 76| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|445 col 82| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|446 col 80| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|447 col 72| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|448 col 74| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/ChargePointRepository.java|42| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/repository/ReservationStatus.java|31| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_Invoker.java|33 col 18| Name 'ChargePointService15_Invoker' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_Invoker.java|31 col 18| Name 'ChargePointService16_Invoker' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|52 col 14| Name 'ChargePointService15_InvokerImpl' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|58| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|66| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|75| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|84| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|93| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|102| Line is longer than 120 characters (found 134).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|112| Line is longer than 120 characters (found 137).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|121| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|130| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|139| Line is longer than 120 characters (found 140).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|148| Line is longer than 120 characters (found 131).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|157| Line is longer than 120 characters (found 135).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|166| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|175| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|184| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|193| Line is longer than 120 characters (found 136).
src/main/java/de/rwth/idsg/steve/ocpp/ws/PingTask.java|50 col 15| Comment matches to-do format 'TODO:'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ocpp15/Ocpp15WebSocketEndpoint.java|79| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/ocpp/ws/WebSocketLogger.java|39| Line is longer than 120 characters (found 127).
src/main/java/de/rwth/idsg/steve/ocpp/ws/WebSocketLogger.java|59| Line is longer than 120 characters (found 144).
src/main/java/de/rwth/idsg/steve/ocpp/ws/data/CommunicationContext.java|65 col 11| Comment matches to-do format 'TODO:'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/data/CommunicationContext.java|71 col 11| Comment matches to-do format 'TODO:'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/OcppWebSocketHandshakeHandler.java|21 col 8| Unused import - de.rwth.idsg.steve.config.WebSocketConfiguration.
src/main/java/de/rwth/idsg/steve/ocpp/ws/OcppWebSocketHandshakeHandler.java|69| Line is longer than 120 characters (found 125).
src/main/java/de/rwth/idsg/steve/ocpp/ws/OcppWebSocketHandshakeHandler.java|121 col 86| ')' is preceded with whitespace.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ocpp12/Ocpp12WebSocketEndpoint.java|79| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/MeterValue15Mixin.java|33 col 22| Variable 'values' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/CustomStringModule.java|60 col 9| Redundant 'public' modifier.
src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/CustomStringModule.java|87| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/ocpp/ws/ocpp16/Ocpp16WebSocketEndpoint.java|79| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/ocpp/ws/AbstractWebSocketEndpoint.java|77| Line is longer than 120 characters (found 139).
src/main/java/de/rwth/idsg/steve/ocpp/ws/AbstractWebSocketEndpoint.java|78| Line is longer than 120 characters (found 145).
src/main/java/de/rwth/idsg/steve/ocpp/ws/ConcurrentWebSocketHandler.java|38 col 30| Name 'sendTimeLimit' must match pattern '^[A-Z][A-Z0-9]
([A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ConcurrentWebSocketHandler.java|39 col 30| Name 'bufferSizeLimit' must match pattern '^[A-Z][A-Z0-9]
(
[A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ConcurrentWebSocketHandler.java|64| Line is longer than 120 characters (found 144).
src/main/java/de/rwth/idsg/steve/ocpp/CommunicationTask.java|55 col 23| Variable 'params' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/ocpp/soap/CentralSystemService15_SoapServer.java|73 col 14| Name 'CentralSystemService15_SoapServer' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/ocpp/soap/CentralSystemService12_SoapServer.java|72 col 14| Name 'CentralSystemService12_SoapServer' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/ocpp/soap/CentralSystemService16_SoapServer.java|70 col 14| Name 'CentralSystemService16_SoapServer' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/ocpp/soap/CentralSystemService16_SoapServer.java|253| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/ocpp/Ocpp15AndAboveTask.java|31| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|33| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|39| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|55| Line is longer than 120 characters (found 136).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|61| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|33| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|39| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|57| Line is longer than 120 characters (found 136).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|63| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Convert.java|27 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16Impl.java|295 col 47| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16Impl.java|296 col 45| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16Impl.java|297 col 49| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16Impl.java|298 col 51| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16Impl.java|299 col 41| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|77| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|96| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|105| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|152| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|167| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|46 col 14| Name 'ChargePointService12_InvokerImpl' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|52| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|60| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|69| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|78| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|87| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|96| Line is longer than 120 characters (found 134).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|105| Line is longer than 120 characters (found 137).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|114| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|123| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|132| Line is longer than 120 characters (found 140).
src/main/java/de/rwth/idsg/steve/ocpp/Ocpp16AndAboveTask.java|31| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/task/RemoteStartTransactionTask.java|57 col 7| Comment matches to-do format 'TODO:'.
src/main/java/de/rwth/idsg/steve/ocpp/task/GetConfigurationTask.java|40| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/task/GetConfigurationTask.java|106 col 5| Class ResponseWrapper should be declared as final.
src/main/java/de/rwth/idsg/steve/ocpp/task/ClearChargingProfileTask.java|70| Line is longer than 120 characters (found 145).
src/main/java/de/rwth/idsg/steve/ocpp/task/GetCompositeScheduleTask.java|36| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/task/SetChargingProfileTask.java|99| Line is longer than 120 characters (found 139).
src/main/java/de/rwth/idsg/steve/ocpp/task/SetChargingProfileTask.java|99 col 73| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/OcppCallback.java|36| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_Invoker.java|36 col 18| Name 'ChargePointService12_Invoker' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|23 col 36| Using the '.' form of import should be avoided - de.rwth.idsg.steve.ocpp.task..
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|38 col 14| Name 'ChargePointService16_InvokerImpl' must match pattern '^[A-Z][a-zA-Z0-9]*$'.
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|44| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|52| Line is longer than 120 characters (found 139).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|61| Line is longer than 120 characters (found 137).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|70| Line is longer than 120 characters (found 139).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|79| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|88| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|97| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|106| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|115| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|124| Line is longer than 120 characters (found 134).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|134| Line is longer than 120 characters (found 137).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|143| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|152| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|161| Line is longer than 120 characters (found 140).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|170| Line is longer than 120 characters (found 131).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|179| Line is longer than 120 characters (found 135).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|188| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|197| Line is longer than 120 characters (found 132).
... (Too many findings. Dropped some findings)

Annotations

Check failure on line 88 in src/main/java/de/rwth/idsg/steve/service/WebUserService.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/main/java/de/rwth/idsg/steve/service/WebUserService.java#L88 <com.puppycrawl.tools.checkstyle.checks.coding.AvoidInlineConditionalsCheck>

Avoid inline conditionals.
Raw output
/github/workspace/./src/main/java/de/rwth/idsg/steve/service/WebUserService.java:88:13: error: Avoid inline conditionals. (com.puppycrawl.tools.checkstyle.checks.coding.AvoidInlineConditionalsCheck)