fix: allow scrolling back in eat read-only mode#126
Open
shir-genesis wants to merge 1 commit intostevemolitor:mainfrom
Open
fix: allow scrolling back in eat read-only mode#126shir-genesis wants to merge 1 commit intostevemolitor:mainfrom
shir-genesis wants to merge 1 commit intostevemolitor:mainfrom
Conversation
The synchronize-scroll function checked `buffer-read-only` to decide whether to snap the viewport back to the terminal cursor. However, `eat-emacs-mode` (used by read-only mode) does not set `buffer-read-only` to t — it clears `eat--semi-char-mode` instead. This caused the scroll function to keep pulling the user back to the bottom even in read-only mode, making it impossible to scroll through history. Fix: check `eat--semi-char-mode` (which is what `claude-code--term-in-read-only-p` already uses) instead of `buffer-read-only`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synchronize-scroll function checked
buffer-read-onlyto decide whether to snap the viewport back to the terminal cursor. However,eat-emacs-mode(used by read-only mode) does not setbuffer-read-onlyto t — it clearseat--semi-char-modeinstead. This caused the scroll function to keep pulling the user back to the bottom even in read-only mode, making it impossible to scroll through history.Fix: check
eat--semi-char-mode(which is whatclaude-code--term-in-read-only-palready uses) instead ofbuffer-read-only.