Merge pull request #141 from colinricardo/main

packages/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "novel",
-  "version": "0.1.19",
+  "version": "0.1.20",
   "description": "Notion-style WYSIWYG editor with AI-powered autocompletions",
   "license": "Apache-2.0",
   "main": "./dist/index.js",

packages/core/src/ui/editor/bubble-menu/index.tsx

@@ -57,18 +57,15 @@ export const EditorBubbleMenu: FC<EditorBubbleMenuProps> = (props) => {
 
   const bubbleMenuProps: EditorBubbleMenuProps = {
     ...props,
-    shouldShow: ({ view, state, editor }) => {
+    shouldShow: ({ state, editor }) => {
       const { selection } = state;
       const { empty } = selection;
-      const hasEditorFocus = view.hasFocus();
 
-      // don't show if image is selected
-      if (
-        editor.isActive("image") ||
-        !hasEditorFocus ||
-        empty ||
-        isNodeSelection(selection)
-      ) {
+      // don't show bubble menu if:
+      // - the selected node is an image
+      // - the selection is empty
+      // - the selection is a node selection (for drag handles)
+      if (editor.isActive("image") || empty || isNodeSelection(selection)) {
         return false;
       }
       return true;

packages/core/src/ui/editor/bubble-menu/link-selector.tsx

@@ -43,7 +43,7 @@ export const LinkSelector: FC<LinkSelectorProps> = ({
         <form
           onSubmit={(e) => {
             e.preventDefault();
-            const input = e.target[0] as HTMLInputElement;
+            const input = e.currentTarget[0] as HTMLInputElement;
             const url = getUrlFromString(input.value);
             url && editor.chain().focus().setLink({ href: url }).run();
             setIsOpen(false);