fix: bump schema version so no_history migration runs on existing DBs#2651
Open
timvisher-dd wants to merge 4 commits intosteveyegge:mainfrom
Open
fix: bump schema version so no_history migration runs on existing DBs#2651timvisher-dd wants to merge 4 commits intosteveyegge:mainfrom
timvisher-dd wants to merge 4 commits intosteveyegge:mainfrom
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Replace the global golangci-lint binary with `go run` pinned to v2.10.1. This ensures golangci-lint is always compiled with the project's Go toolchain, eliminating version-mismatch panics when the global binary was built with an older Go (e.g., 1.25) than the runtime (e.g., 1.26). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PR steveyegge#2622 added migration 011 (add_no_history_column) but did not bump currentSchemaVersion. Databases already at version 7 take the fast path in initSchemaOnDB and skip RunMigrations entirely, causing "column no_history could not be found" errors on every bd command. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…60.0 entries The 0.61.0 version bump appended the entry at the end of the versionChanges array instead of prepending it. This broke TestGetVersionsSinceOrder which expects newest-first ordering. Also merges the two separate 0.60.0 entries into one. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2d7a099 to
2fc7074
Compare
The embedded Dolt schema migrations were missing the no_history column added by migration 011 in the regular Dolt path, causing all embedded Dolt CI tests to fail with "Unknown column 'no_history' in 'issues'". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currentSchemaVersionfrom 7 to 8 so thatinitSchemaOnDBre-runs migrations on databases already at version 7. PR feat: add --no-history flag to separate Dolt commit skipping from GC eligibility #2622 added migration 011 (add_no_history_column) but did not bump the schema version, so existing databases take the fast path and skipRunMigrations, causing"column no_history could not be found"on everybdcommand.golangci-lintbinary withgo runin the pre-commit hook, pinned to v2.10.1. This ensures the linter is always compiled with the project's Go toolchain, eliminating panics when the global binary was built with an older Go than the runtime (e.g., golangci-lint built with 1.25 vs runtime 1.26).versionChangesordering ininfo.go— the 0.61.0 entry was appended at the end instead of prepended, breakingTestGetVersionsSinceOrder. Also merges two duplicate 0.60.0 entries into one.no_historycolumn migration for embedded Dolt — the embedded Dolt schema migrations were missing theno_historycolumn, causing all embedded Dolt CI tests to fail.Test plan
bd ready/bd lsagainst a.beadsdatabase created before theno_historycolumn existed — succeeds without errorsschema_versionin the config table is updated to 8 after first run.gofile change and confirm the pre-commit hook runsgo run golangci-lintsuccessfully without requiring a global installTestGetVersionsSinceOrderpasses