Commits on Mar 29, 2020

1. Fix translucent navbar for Android 10 …

   When the status bar is _not_ hidden, past behavior was for the
   navigation bar to be translucent. On Android 10 (SDK 29), it is opaque
   black. This patch restores and improves upon past behavior by ensuring a
   fully transparent nav bar when gesture controls are enabled (and
   using the system-provided translucent scrim when 3-button navigation
   is enabled).
   
   To achieve this we need to switch from using
   android:windowTranslucentNavigation to using android:navigationBarColor.
   On Android 10, it appears android:windowDrawsSystemBarBackgrounds
   must be set for android:navigationBarColor to have any affect.
   (I wonder if this is related to being an AlertDialog.)
   android:windowDrawsSystemBarBackgrounds is not supported in SDK < 21,
   whereas this library supports SDK >= 19, so I've created a separate
   styles.xml file for SDK >= 29.
   
   Setting systemUiVisibility flags appears to be necessary to get
   the transparent nav bar effect. It seems that setting
   android:windowTranslucentNavigation was providing the same effect
   as setting these flags, but now it needs to be done manually for
   SDK >= 29 as android:windowTranslucentNavigation is not set.

   

   svank committed Mar 29, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 27c248e
   • Browse repository at this point

   Copy the full SHA

   27c248e View commit details

   Browse the repository at this point in the history