Switch to Dialog Fragment #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched the dialog to DialogFragment so when a configuration change (i.e. orientation) happens the dialog will still be there. Updated the listeners passed in to just call out to the hosting activity.
|
I am very much open to all comments and changes considering this is such a huge change. |
Allow the dialog to be presented from a fragment and have the callbacks work.
|
Why is this not merged yet? The library is unusable right now due to it dismissing on configuration changed. Has the owner left it to rot? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched the dialog to DialogFragment so
when a configuration change (i.e. orientation) happens the
dialog will still be there.
Updated the listeners passed in to just call out to the
hosting activity.