Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload setCurrentPosition() to allow disabling the scroll animation #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

svank
Copy link
Contributor

@svank svank commented Mar 29, 2020

Here's another PR for when you get a chance to poke at this library some more. I have a use case that benefits from the setCurrentPosition() method that was added in 1.0.0, but this use case also looks nicer if there's no animation when the viewer changes the image being displayed. (The image is changed when returning from an activity that was launched while viewing an image.) In case it's useful to others, here's my patch to add an optional second argument to setCurrentPosition which controls the smooth scroll animation (true=animation, false=no animation). The one-argument form continues to use the animation, so there's no change to existing code using the library. The value of that second argument is passed through to the two-argument form of setCurrentItem in the androidx ViewPager that MultiTouchViewPager extends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant