Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing read_list_by_name looping on MAX_ADS_SUB_COMMANDS case with lo… #438

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fixing read_list_by_name looping on MAX_ADS_SUB_COMMANDS case with lo… #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pyads/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,8 +598,9 @@ def sum_read(port: int, adr: AmsAddr, data_names: List[str],
list(structure_defs.keys())) # type: ignore

for data_name, structure_def in structure_defs.items(): # type: ignore
result[data_name] = dict_from_bytes(result[data_name],
structure_def) # type: ignore
if data_name in result:
result[data_name] = dict_from_bytes(result[data_name],
structure_def)

return result

Expand Down Expand Up @@ -691,7 +692,7 @@ def write_by_name(
return adsSyncWriteByNameEx(
self._port, self._adr, data_name, value, plc_datatype, handle=handle
)

def write_list_by_name(
self,
data_names_and_values: Dict[str, Any],
Expand Down
Loading