Use statically typed time consistently #231
Conversation
|
Oh, and I want to do another patch release with some doc improvements and some non-breaking PRs, so we should probably hold off on merging this until that is done. |
| @@ -1,16 +1,17 @@ | |||
| //! Inter-Integrated Circuit (I2C) bus | |||
There was a problem hiding this comment.
What's the reason for the comment style change? C++ comments are not so typical in the Rust world.
There was a problem hiding this comment.
Oops, I think I started adding a larger doc chunk, but then changed my mind about what I wanted to do. I'll revert it until I get around to adding i2c docs
There was a problem hiding this comment.
Even then it should be possible to use Rust style comments. ;)
There was a problem hiding this comment.
Sure, but I kind of dislike that for large blocks, especially inserting new lines
|
Of course, I can't just break the tradition of forgetting to include changelogs with changes :) |
|
Can we use this? |
|
Yes, that's probably a better idea than using our own structs. I'll port our code over to that |
|
Looks like using unsigned base types with |
Closes #230
Replaces the uses of
_msand_uspostfix variables withMicrosecondandMillisecondtypes. I also renamed the types to use a lowercase S which I believe is more correct. It's the way wikipedia spells it at least :) https://en.wikipedia.org/wiki/MicrosecondThis is built on top of #229 as that was where a lot of the
usoccurrences were.