Re-introduced possibility of DMA peripheral abstraction, and added SPI DMA abstraction example #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fers. Also added dynamically generated data, and transmission in a continuous loop.
…or use via abstraction.
johnnyegel
changed the title
…pecify it explicitly in examples. This means all examples are as they where before re-adding the trait.
|
Added changelog entry for change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the Transferable trait has been removed in 0.7.0. This seems to make it impossible to create functions which takes an abstract SPI DMA reference and transmit data via it. A real life use-case for this is in multipurpose drivers, which should work with any SPI peripheral and possibly share it with other drivers.
I've also improved the SPI-DMA example to showcase this exact use case. As a side perk, this will break if pure abstract referencing is ever broken. Thus hopefully insuring this feature is retained in the HAL for the Future.
NOTE! I really think this DMA scheme should be defined on a higher level, and be shared across all the HALs.
Also NOTE! I am very much a noob in Rust (though I have a long experience in MCU/Embedded development in C), so please go easy on me if this is udder crap :)