split Serial PINS #392
Open
split Serial PINS #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
force-pushed
the
usart-pins
branch
2 times, most recently
from
51f919b to
d009003
Compare
horazont
reviewed
Jan 10, 2022
There was a problem hiding this comment.
Right, that would work. However, I think this points at a problem with the API: https://github.com/stm32-rs/stm32f1xx-hal/pull/392/files#diff-6c6f014a7f636e0dd1ce76320128a53b7bed96a29540822c340aeba0d9c9c1fdR23-R24
Now, the interrupt implementation (which cannot be easily generalized because it needs a static) depends on the pins used for the serial peripheral. Given that, I'd still want to introduce a pin-erased version of Serial, Tx and Rx. Nonetheless, I agree that #392 is a better standalone fix for #386 than #390.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #390