Skip to content

Commit

Permalink
Fix shared reference of mutable static warning (#234)
Browse files Browse the repository at this point in the history
This fixes this warning:

warning: shared reference of mutable static is discouraged
  --> stm32l0xx-hal/src/signature.rs:45:40
   |
45 |         core::str::from_utf8_unchecked(&DEVICE_ID_STR)
   |                                        ^^^^^^^^^^^^^^ shared reference of mutable static
   |
   = note: for more information, see issue #114447 <rust-lang/rust#114447>
   = note: reference of mutable static is a hard error from 2024 edition
   = note: mutable statics can be written to by multiple threads: aliasing violations or data races will cause undefined behavior
   = note: `#[warn(static_mut_ref)]` on by default
help: shared references are dangerous since if there's any kind of mutation of that static while the reference lives, that's UB; use `addr_of!` instead to create a raw pointer

Co-authored-by: Javier Cardona <[email protected]>
  • Loading branch information
jcard0na and Javier Cardona authored Jan 27, 2024
1 parent d20524c commit 7132578
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/signature.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ pub fn device_id_hex() -> &'static str {
});
}

core::str::from_utf8_unchecked(&DEVICE_ID_STR)
core::str::from_utf8_unchecked(&*core::ptr::addr_of!(DEVICE_ID_STR))
}
}

Expand Down

0 comments on commit 7132578

Please sign in to comment.